Skip to content

Rename stable_mir and rustc_smir #143848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Rename stable_mir and rustc_smir #143848

wants to merge 1 commit into from
+276 −266

Conversation

makai410
Copy link
Contributor

This PR only renames the two crate names.

There is no doubt that we want to rename stable_mir to rustc_public, while it hasn't been discussed yet that what the new name for rustc_smir should be.

This PR proposes a new name for rustc_smir, that is rustc_public_shim, since rustc_smir now is mostly a proxy to do calls to rustc queries and the public API of rustc that is invoked by the rustc_public crate.

However, I don't think that name is good enough. I hope there would be a way better name.

r? @oli-obk

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 12, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 12, 2025

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@makai410 @rustbot @oli-obk